On 10/21/22 15:41, Zhang, Qi Z wrote:
Hi Andrew:
-----Original Message-----
From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
Sent: Friday, October 21, 2022 3:48 PM
To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z
<qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, Beilei
<beilei.x...@intel.com>
Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun...@intel.com>; Wang, Xiao W
<xiao.w.w...@intel.com>
Subject: Re: [PATCH v9 02/14] net/idpf: add support for device initialization
On 10/21/22 10:39, Andrew Rybchenko wrote:
On 10/21/22 08:18, Junfeng Guo wrote:
Support device init and add the following dev ops skeleton:
- dev_configure
- dev_start
One more question: are you sure that you can start without
queues setup?
I agree the patch set is not well-ordered. Keeping each increment be measurable
is a good practice. We should keep this in mind.
But not sure if this is a blocking issue for patch merging as we saw the risk
to have this in RC2 if we must to rework for this.
Btw, the first version of idpf PMD is quite simple. It's very similar to iavf
PMD but has a few features,
I see. IMHO there are too many very similar Intel drivers which
just blow up code base. Just my opinion. Nothing else.
so I hope the out-of-order issue may not downgrade the readability :)
Please kindly give your suggestion.
Thanks
Qi
