On Thu, 20 Oct 2022 at 22:46, Akhil Goyal <gak...@marvell.com> wrote: > > > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > > > UADK is a framework for user applications to access hardware accelerators. > > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > > the same page table between IOMMU and MMU. > > Thereby user application can directly use virtual address for device dma, > > which enhances the performance as well as easy usability. > > > > [1] https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__github.com_Linaro_uadk&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=Dn > > L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=AkCizMeraG64B9u- > > h4gp5S2CYP3SiD5dpvFqvj2WHC4Cfuw6TbzZSeCk1Ryz-qLo&s=Tm7UGDJ- > > 3QUjCzOkIRUG_tjJA3ckOdK6kSOxuk7V5PQ&e= > > > > Test: > > sudo dpdk-test --vdev=crypto_uadk (--log-level=6) > > RTE>>cryptodev_uadk_autotest > > RTE>>quit > > > > Update in v4: > > Akril suggest dpdk use pkg-config, So > > Enable uadk support x86 local build, and support pkg-config. > > Use pkg-config feature for the uadk crypto pmd. > > Add build uadk library steps in doc > > Test on both x86 and arm. > > x86 can build and install, but can not test since no device. > > > I tried with the latest TOT of UADK. This resolved the openssl issue. > But it does not allow me to install UADK into a specific directory. > It installs /usr/local/lib only. > And what is the use of pkg-config if I cannot use a specific directory > To install the libs and headers. > > And even if I install at default location, I am seeing below errors while > compiling DPDK > > [2453/3738] Compiling C object > 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o'. > FAILED: > drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o > ccache cc -Idrivers/a715181@@tmp_rte_crypto_uadk@sta -Idrivers -I../drivers > -Idrivers/crypto/uadk -I../drivers/crypto/uadk -Ilib/cryptodev > -I../lib/cryptodev -I. -I../ -Iconfig -I../config -Ilib/eal/include > -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include > -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common > -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry > -I../lib/telemetry -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool > -Ilib/ring -I../lib/ring -Ilib/rcu -I../lib/rcu -Idrivers/bus/vdev > -I../drivers/bus/vdev -I/usr/local/include -fdiagnostics-color=always -pipe > -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h > -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes > -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation > -DRTE_LOG_DEFAULT_LOGTYPE=pmd.crypto.uadk -MD -MQ > 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' > -MF > 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o.d' > -o 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' > -c ../drivers/crypto/uadk/uadk_crypto_pmd.c > ../drivers/crypto/uadk/uadk_crypto_pmd.c:9:10: fatal error: rte_comp.h: No > such file or directory > 9 | #include <rte_comp.h> > | ^~~~~~~~~~~~ > compilation terminated. > > ninja: Entering directory `build' > [65/1253] Compiling C object > 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o'. > FAILED: > drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o > ccache cc -Idrivers/a715181@@tmp_rte_crypto_uadk@sta -Idrivers -I../drivers > -Idrivers/crypto/uadk -I../drivers/crypto/uadk -Ilib/cryptodev > -I../lib/cryptodev -I. -I../ -Iconfig -I../config -Ilib/eal/include > -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include > -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common > -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry > -I../lib/telemetry -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool > -Ilib/ring -I../lib/ring -Ilib/rcu -I../lib/rcu -Idrivers/bus/vdev > -I../drivers/bus/vdev -I/usr/local/include -fdiagnostics-color=always -pipe > -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h > -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes > -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation > -DRTE_LOG_DEFAULT_LOGTYPE=pmd.crypto.uadk -MD -MQ > 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' > -MF > 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o.d' > -o 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' > -c ../drivers/crypto/uadk/uadk_crypto_pmd.c > ../drivers/crypto/uadk/uadk_crypto_pmd.c:11:10: fatal error: > uadk/wd_cipher.h: No such file or directory > 11 | #include <uadk/wd_cipher.h> >
We originally install header file under uadk folder, like /usr/local/include/uadk/xx.h After switch to pkgconfig, the uadk is removed, like /usr/local/include/xx.h After re-thinking, we still think using the folder uadk will be better and cleaner, without polluting the system, like openssl, also for back-compatibility. So fix the uadk lib by using pkginclude_HEADERS and nobase_pkginclude_HEADERS accordingly. Thanks
