> -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@amd.com> > Sent: Friday, October 21, 2022 17:51 > To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; > ferruh.yi...@xilinx.com; Xing, Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun...@intel.com>; > awogbem...@google.com; Richardson, Bruce > <bruce.richard...@intel.com>; hemant.agra...@nxp.com; > step...@networkplumber.org; Xia, Chenbo <chenbo....@intel.com>; > Zhang, Helin <helin.zh...@intel.com> > Subject: Re: [PATCH v7 6/8] net/gve: add support for dev info get and dev > configure > > On 10/21/2022 10:19 AM, Junfeng Guo wrote: > > > > > Add dev_ops dev_infos_get. > > Complete dev_configure with RX offloads force enabling. > > > > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com> > > Signed-off-by: Junfeng Guo <junfeng....@intel.com> > > <...> > > > --- a/doc/guides/nics/gve.rst > > +++ b/doc/guides/nics/gve.rst > > @@ -62,6 +62,7 @@ In this release, the GVE PMD provides the basic > functionality of packet > > reception and transmission. > > Supported features of the GVE PMD are: > > > > +- Receiver Side Scaling (RSS) > > [copy/paste from previous version] > > I am not sure if driver can claim this, I can see a RSS hash is provided > but is it possible to update which hash function to use or update key or > RETA table to configure which queue packets goes? > > Right now what is RSS calculated on? > > Perpaps RSS support can be documented as limited? > > And not sure if this update belongs this patch, it should be to the one > that has the datapath.
Looks that the RSS is enabled by default, and there is no RSS init API. So I just added back the force-enabled RSS offloading code with the corresponding commit message. So the feature list remains unchaged. Thanks!
