> -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@amd.com> > Sent: Thursday, October 20, 2022 22:46 > To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, > Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun...@intel.com>; > awogbem...@google.com; Richardson, Bruce > <bruce.richard...@intel.com>; hemant.agra...@nxp.com; > step...@networkplumber.org; Xia, Chenbo <chenbo....@intel.com>; > Zhang, Helin <helin.zh...@intel.com> > Subject: Re: [PATCH v6 6/8] net/gve: add support for dev info get and dev > configure > > On 10/20/2022 11:36 AM, Junfeng Guo wrote: > > > > > Add dev_ops dev_infos_get. > > Complete dev_configure with RX offloads configuration. > > > > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com> > > Signed-off-by: Junfeng Guo <junfeng....@intel.com> > > --- > > doc/guides/nics/features/gve.ini | 2 ++ > > doc/guides/nics/gve.rst | 1 + > > drivers/net/gve/gve_ethdev.c | 56 > +++++++++++++++++++++++++++++++- > > 3 files changed, 58 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/nics/features/gve.ini > b/doc/guides/nics/features/gve.ini > > index d1703d8dab..986df7f94a 100644 > > --- a/doc/guides/nics/features/gve.ini > > +++ b/doc/guides/nics/features/gve.ini > > @@ -4,8 +4,10 @@ > > ; Refer to default.ini for the full list of available PMD features. > > ; > > [Features] > > +Speed capabilities = Y > > Link status = Y > > MTU update = Y > > +RSS hash = Y > > I think this was added because of 'RTE_ETH_RX_OFFLOAD_RSS_HASH', it > is > OK to keep this feature if you add force enabling above offload, > otherwise please remove the feature.
Sure, will keep this with the force enabling code at dev config stage. Thanks! > > > Linux = Y > > x86-32 = Y > > x86-64 = Y > > diff --git a/doc/guides/nics/gve.rst b/doc/guides/nics/gve.rst > > index c42ff23841..8c09a5a7fa 100644 > > --- a/doc/guides/nics/gve.rst > > +++ b/doc/guides/nics/gve.rst > > @@ -62,6 +62,7 @@ In this release, the GVE PMD provides the basic > functionality of packet > > reception and transmission. > > Supported features of the GVE PMD are: > > > > +- Receiver Side Scaling (RSS) > > I am not sure if driver can claim this, I can see a RSS hash is provided > but is it possible to update which hash function to use or update key or > RETA table to configure which queue packets goes? > > Right now what is RSS calculated on? > > Perpaps RSS support can be documented as limited? > > And not sure if this update belongs this patch, it should be to the one > that has the datapath. Same for this, thanks! >
