On 10/20/2022 12:48 PM, Chaoyong He wrote:
On 10/20/2022 3:19 AM, Chaoyong He wrote:
Add the corresponding data structure and logics, to support the
offload of set source MAC action.
Signed-off-by: Chaoyong He <chaoyong...@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderl...@corigine.com>
<...>
+ case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
+ PMD_DRV_LOG(DEBUG, "Process
RTE_FLOW_ACTION_TYPE_SET_MAC_SRC");
+ nfp_flow_action_set_mac(position, action, true,
mac_set_flag);
+ if (!mac_set_flag) {
+ position += sizeof(struct nfp_fl_act_set_eth);
+ mac_set_flag = true;
+ }
Hi Andrew, Ori,
I can see 'RTE_FLOW_ACTION_TYPE_SET_MAC_SRC' and many other
marked as legacy and reference to
'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD'.
What is the expectation from PMD developers for this?
User still can provide these legacy actions, right? So should PMD implement
both legacy and new ones?
From my side, we trying to implement the basic offload in this DPDK release,
and complete
the missing pieces in the next few DPDK releases.
The support of 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD' is in the very next project
after
this series.
Sounds reasonable to me, but also I am not aware of the long term plan
there, so I need input from Andrew and Ori.
