Hello Ciara,

On Thu, Oct 20, 2022 at 11:54 AM Power, Ciara <ciara.po...@intel.com> wrote:
> This is a nice addition to the library.
>
> > -----Original Message-----
> > From: David Marchand <david.march...@redhat.com>
> > Sent: Wednesday 19 October 2022 08:37
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richard...@intel.com>;
> > m...@smartsharesystems.com; Power, Ciara <ciara.po...@intel.com>
> > Subject: [PATCH] telemetry: support boolean type
> >
> > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts.
> >
> > Signed-off-by: David Marchand <david.march...@redhat.com>
> > ---
> >  app/test/test_telemetry_data.c | 88 +++++++++++++++++++++++++++++++++-
> >  lib/telemetry/rte_telemetry.h  | 36 ++++++++++++++
> >  lib/telemetry/telemetry.c      | 24 +++++++++-
> >  lib/telemetry/telemetry_data.c | 44 +++++++++++++++--
> > lib/telemetry/telemetry_data.h |  5 ++  lib/telemetry/telemetry_json.h | 34
> <snip>
>
> Acked-by: Ciara Power <ciara.po...@intel.com>

Thank you.

Fyi, I'll respin this patch to fix Bruce comments.
I will send it as preparation for the trace telemetry additions.


-- 
David Marchand

Reply via email to