On Fri, 29 May 2015 16:45:25 +0800
Cunming Liang <cunming.liang at intel.com> wrote:
> +#ifdef RTE_EAL_RX_INTR
> +extern int
> rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data);
> +#else
> +static inline int
> +rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data)
> +{
> + RTE_SET_USED(port_id);
> + RTE_SET_USED(epfd);
> + RTE_SET_USED(op);
> + RTE_SET_USED(data);
> + return -1;
> +}
> +#endif
Doing ABI compatibility is good but hard.
I think it would be better not to provide the functions for rx_intr_ctl unless
the feature was configured on. That way anyone using them with incorrect config
would detect failure at build time, rather than run time.
Also, doesn't some doc file have to be updated for the announcement?
