Hi Stephen, thanks for your comments. The original goal of this patch is to close the 'eal-intr-thread' to fix segfaults caught by Asan. But it breaks the debug_autotest unit test.
So the flag is added to fix the unit test. Hi @David Marchand, what's your suggestions? BR Zhichao > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Tuesday, October 11, 2022 10:04 PM > To: Zeng, ZhichaoX <zhichaox.z...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org; Zhou, YidingX > <yidingx.z...@intel.com>; Richardson, Bruce > <bruce.richard...@intel.com>; Harman Kalra <hka...@marvell.com> > Subject: Re: [PATCH v6] lib/eal: fix segfaults in exiting > > On Tue, 11 Oct 2022 13:25:14 +0800 > Zhichao Zeng <zhichaox.z...@intel.com> wrote: > > > This patch closes the 'eal-intr-thread' before memory cleanup in > > 'rte_eal_cleanup' to avoid segfaults, and adds a flag to avoid > > executing 'rte_eal_cleanup' in the child process which is forked to > > execute some test cases(e.g. debug_autotest of dpdk-test > > This is a test bug, not an DPDK bug. I don't think DPDK should account for > misuse of API in this way.
