[PATCH v2] net/bonding: make bonded device configure method re-entrant

[Ivan Malov]

According to the documentation, rte_eth_dev_configure()
can be invoked repeatedly while in stopped state.
The current implementation in the bonding driver
allows for that (technically), but the user sees
warnings which say that back-end devices have
already been harnessed. Re-factor the code
to have cleanup before each (re-)configure.

Signed-off-by: Ivan Malov <ivan.ma...@oktetlabs.ru>
Reviewed-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
Acked-by: Chas Williams <3ch...@gmail.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c 
b/drivers/net/bonding/rte_eth_bond_pmd.c
index 27005c747c..486b7fc9f7 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2148,18 +2148,14 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)
        return 0;
 }
 
-int
-bond_ethdev_close(struct rte_eth_dev *dev)
+static void
+bond_ethdev_cfg_cleanup(struct rte_eth_dev *dev)
 {
        struct bond_dev_private *internals = dev->data->dev_private;
        uint16_t bond_port_id = internals->port_id;
        int skipped = 0;
        struct rte_flow_error ferror;
 
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-               return 0;
-
-       RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name);
        while (internals->slave_count != skipped) {
                uint16_t port_id = internals->slaves[skipped].port_id;
 
@@ -2178,6 +2174,20 @@ bond_ethdev_close(struct rte_eth_dev *dev)
                }
        }
        bond_flow_ops.flush(dev, &ferror);
+}
+
+int
+bond_ethdev_close(struct rte_eth_dev *dev)
+{
+       struct bond_dev_private *internals = dev->data->dev_private;
+
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name);
+
+       bond_ethdev_cfg_cleanup(dev);
+
        bond_ethdev_free_queues(dev);
        rte_bitmap_reset(internals->vlan_filter_bmp);
        rte_bitmap_free(internals->vlan_filter_bmp);
@@ -3610,6 +3620,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
 
        unsigned i, j;
 
+
+       bond_ethdev_cfg_cleanup(dev);
+
        /*
         * If RSS is enabled, fill table with default values and
         * set key to the value specified in port RSS configuration.
-- 
2.30.2