RE: [PATCH] net/virtio: add queue and port ID in some logs

[Xia, Chenbo]

Hi Olivier,

> -----Original Message-----
> From: Olivier Matz <olivier.m...@6wind.com>
> Sent: Thursday, September 29, 2022 8:22 PM
> To: dev@dpdk.org
> Cc: Maxime Coquelin <maxime.coque...@redhat.com>; Xia, Chenbo
> <chenbo....@intel.com>
> Subject: [PATCH] net/virtio: add queue and port ID in some logs
> 
> Add the queue id and/or the port id in some logs, so it is easier to
> understand what happens.
> 
> Signed-off-by: Olivier Matz <olivier.m...@6wind.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 6 ++++--
>  drivers/net/virtio/virtio_rxtx.c   | 3 ++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/drivers/net/virtio/virtio_ethdev.c
> index 7e07270a8b..44811c299b 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -2807,7 +2807,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
>                       return -EINVAL;
>       }
> 
> -     PMD_INIT_LOG(DEBUG, "nb_queues=%d", nb_queues);
> +     PMD_INIT_LOG(DEBUG, "nb_queues=%d (port=%d)", nb_queues,
> +                  dev->data->port_id);

Better to use %u for all port_id since it's uint16_t

Thanks,
Chenbo

> 
>       for (i = 0; i < dev->data->nb_rx_queues; i++) {
>               vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> @@ -2821,7 +2822,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
>               virtqueue_notify(vq);
>       }
> 
> -     PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
> +     PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=%d)",
> +                  dev->data->port_id);
> 
>       for (i = 0; i < dev->data->nb_rx_queues; i++) {
>               vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> diff --git a/drivers/net/virtio/virtio_rxtx.c
> b/drivers/net/virtio/virtio_rxtx.c
> index 4795893ec7..f8a9ee5cdb 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev
> *dev, uint16_t queue_idx)
>                       vq_update_avail_idx(vq);
>       }
> 
> -     PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs);
> +     PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=%d queue=%d)", nbufs,
> +                  dev->data->port_id, queue_idx);
> 
>       VIRTQUEUE_DUMP(vq);
> 
> --
> 2.30.2