> -----Original Message----- > From: Simon K?gstr?m [mailto:simon.kagstrom at netinsight.net] > Sent: Thursday, May 28, 2015 12:37 PM > To: Wodkowski, PawelX; Zhang, Helin; Alexander Guy; Julien Cretin; Buriez, > Patrice > Cc: dev at dpdk.org > Subject: Re: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version > > On 2015-05-28 12:05, Wodkowski, PawelX wrote: > >>> > >>> -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \ > >>> - cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comma)) > >>> +UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE > >>> $(RTE_KERNELDIR)/include/generated/utsrelease.h \ > >>> + | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1) > > > > It is fine for me if it do the job and does not break build on other OS > > (also other > > Ubuntu versions especially 12.04 if we still support it). > > Please only check if UTS_RELEASE is available on all Ubuntu versions DPDK > support. > > From some digging, it appears it entered the kernel tree in 2006 and > moved to include/generated/ in 2009 so I guess that should be fine for > DPDK builds? > > // Simon
I also think that it is OK but I also think should check by building you (o ask someone to do it for you) on those systems not by theory :) -- Pawel
