> On Sep 23, 2022, at 12:13 AM, David Marchand <david.march...@redhat.com>
> wrote:
>
> On Thu, Sep 22, 2022 at 12:29 AM Harris, James R
> <james.r.har...@intel.com> wrote:
>>
>>
>> So sticking with the internal header copies for now, this works fine
>> for LTS and non-LTS releases. What about stable releases (i.e. 22.11.1)?
>> IIUC, these header files could change in a stable release since they are
>> no longer part of the ABI?
>
> In theory, yes they can change.
> But this is a price to pay, as no one seems willing to invest and
> maintain a stable API for PCI drivers.
Understood. SPDK is preparing for this possibility, just wanted to confirm
it was necessary.
> I just noticed that some parts of the cleanups I had proposed have
> been merged in SPDK.
> Next time, I prefer getting some feedback from SPDK community before
> my SoB is applied (or stripped) on modified patches.
My apologies David. The RTE_DEV_FOREACH cleanup was a nice one and an obvious
improvement. I believe it was applied without any modifications (except for
fuzz offsets) but still should have given you a heads-up.
-Jim
