Acked-by: Kai Ji <kai...@intel.com>
> -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Wednesday, September 21, 2022 4:03 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; vattun...@marvell.com; > ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > konstantin.v.anan...@yandex.ru; jiawe...@trustnetic.com; > yisen.zhu...@huawei.com; irussk...@marvell.com; jer...@marvell.com; > adwiv...@marvell.com; maxime.coque...@redhat.com; cha...@amd.com; > ruifeng.w...@arm.com; ajit.khapa...@broadcom.com; > ano...@marvell.com; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com>; ma...@nvidia.com; g.si...@nxp.com; > Yang, Qiming <qiming.y...@intel.com>; Wu, Wenjun1 > <wenjun1...@intel.com>; jianw...@trustnetic.com; Wu, Jingjing > <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; > ndabilpu...@marvell.com; Akhil Goyal <gak...@marvell.com>; Zhang, Roy > Fan <roy.fan.zh...@intel.com> > Subject: [PATCH v2 1/6] cryptodev: rework session framework > > As per current design, rte_cryptodev_sym_session_create() and > rte_cryptodev_sym_session_init() use separate mempool objects > for a single session. > And structure rte_cryptodev_sym_session is not directly used > by the application, it may cause ABI breakage if the structure > is modified in future. > > To address these two issues, the rte_cryptodev_sym_session_create > will take one mempool object that the session and session private > data are virtually/physically contiguous, and initializes both > fields. The API rte_cryptodev_sym_session_init is removed. > > rte_cryptodev_sym_session_create will now return an opaque session > pointer which will be used by the app and other APIs. > > In data path, opaque session pointer is attached to rte_crypto_op > and the PMD can call an internal library API to get the session > private data pointer based on the driver id. > > Note: currently single session may be used by different device > drivers, given it is initialized by them. After the change the > session created by one device driver cannot be used or > reinitialized by another driver. > > Signed-off-by: Akhil Goyal <gak...@marvell.com> > Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com> > ---
