Hi Akhil, 

> -----Original Message-----
> From: Akhil Goyal <gak...@marvell.com>
> 
> > diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index
> > ed528b8..b7ecf94 100644
> > --- a/lib/bbdev/rte_bbdev.h
> > +++ b/lib/bbdev/rte_bbdev.h
> > @@ -224,6 +224,19 @@ struct rte_bbdev_queue_conf {
> > rte_bbdev_queue_stop(uint16_t dev_id, uint16_t queue_id);
> >
> >  /**
> > + * Flags indicate the reason why a previous enqueue may not have
> > + * consumed all requested operations
> > + * In case of multiple reasons the latter superdes a previous one
> Spell check - supersedes.

Thanks, fixed in v8.

> 
> > + */
> > +enum rte_bbdev_enqueue_status {
> > +   RTE_BBDEV_ENQ_STATUS_NONE,             /**< Nothing to report */
> > +   RTE_BBDEV_ENQ_STATUS_QUEUE_FULL,       /**< Not enough room
> in
> > queue */
> > +   RTE_BBDEV_ENQ_STATUS_RING_FULL,        /**< Not enough room
> in
> > ring */
> > +   RTE_BBDEV_ENQ_STATUS_INVALID_OP,       /**< Operation was
> > rejected as invalid */
> > +   RTE_BBDEV_ENQ_STATUS_PADDED_MAX = 6,   /**< Maximum enq
> > status number including padding */
> 
> Are we ok to have this kind of padding across DPDK for all the enums to
> avoid ABI issues?
> @Ray, @Thomas: any thoughts?
> 

This was discussed at the time notably with advises from Ray. But good to close 
the loop formally. 

Reply via email to