On 8/26/2022 6:39 AM, Chaoyong He wrote:
From: James Hershaw <james.hers...@corigine.com>Prepend `0x` to the NFP HWINFO header value that is printed to improve the readability of the printed statement. Signed-off-by: James Hershaw <james.hers...@corigine.com> Reviewed-by: Chaoyong He <chaoyong...@corigine.com> Reviewed-by: Niklas Söderlund <niklas.soderl...@corigine.com> --- drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c index c0516bf..9f848bd 100644 --- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c +++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c @@ -108,7 +108,7 @@ goto exit_free;header = (void *)db;- printf("NFP HWINFO header: %08x\n", *(uint32_t *)header); + printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header);
Why driver is directly using 'printf', but not rte_log APIs? I can see there are already 'PMD_INIT_LOG' & 'PMD_DRV_LOG' macros for this.
