> > >>> struct rte_event_vector { > > >>> uint16_t nb_elem; > > >>> - /**< Number of elements in this event vector. */ > > >>> - uint16_t rsvd : 15; > > >>> + /**< Total number of elements in this event vector. */ > > >> > > >> I'm not sure "total" adds anything here. Didn't the old nb_elem also > > >> include the total number of elements? > > >> > > > > > > Yes, I added it to clarify that it includes slots that don’t have valid > > > elements. > > > I will update the comment to convey that it includes elements before > > offset. > > > > > > > The issue is that it doesn't clarify anything. Change the name, or > > change the semantics to fit the name, instead of explaining a poor name > > in a comment. > > > > Names are always subjective and will confuse someone or the other. > But we can do our best to communicate the semantics, how about > total_(elements|slots|lanes) and valid_(element|slot|lane)_offset. > > I will send the next version once we agree upon the naming.
In order to make forward progress, @Mattias Rönnblom Do you have specific name suggestions for the next version? If not, I suggest to pick total_elements