> -----Original Message----- > From: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > Sent: Wednesday, September 14, 2022 1:31 AM > To: Juraj Linkeš <juraj.lin...@pantheon.tech>; Bruce Richardson > <bruce.richard...@intel.com> > Cc: tho...@monjalon.net; david.march...@redhat.com; > ronan.rand...@intel.com; ohily...@iol.unh.edu; lijuan...@intel.com; > dev@dpdk.org; nd <n...@arm.com>; nd <n...@arm.com> > Subject: RE: [PATCH v4 3/9] dts: add basic logging facility > > <snip> > > > > > > > --- > > > > dts/framework/__init__.py | 3 + > > > > dts/framework/logger.py | 124 > > > ++++++++++++++++++++++++++++++++++++++ > > > > 2 files changed, 127 insertions(+) create mode 100644 > > > > dts/framework/__init__.py create mode 100644 > > > > dts/framework/logger.py > > > > > > > > diff --git a/dts/framework/__init__.py b/dts/framework/__init__.py > > > > new file mode 100644 index 0000000000..3c30bccf43 > > > > --- /dev/null > > > > +++ b/dts/framework/__init__.py > > > > @@ -0,0 +1,3 @@ > > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > > +PANTHEON.tech s.r.o. > > > > +# > > > > diff --git a/dts/framework/logger.py b/dts/framework/logger.py new > > > > file mode 100644 index 0000000000..920ce0fb15 > > > > --- /dev/null > > > > +++ b/dts/framework/logger.py > > > > @@ -0,0 +1,124 @@ > > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2010-2014 > > > > +Intel Corporation # Copyright(c) 2022 PANTHEON.tech s.r.o. > > > > +# Copyright(c) 2022 University of New Hampshire # > > > > + > > > > +import logging > > > > +import os.path > > > > +from typing import TypedDict > > > > + > > > > +""" > > > > +DTS logger module with several log level. DTS framework and > > > > +TestSuite log will saved into different log files. > Nit "DTS logger module with several log levels. DTS framework and TestSuite > logs are saved in different log files." >
Thanks, these nitpicks are important - there are a lot comments from the original authors that need ironing out. Although I this one particular example was written be either me or Owen. :-) > <snip>
