Hi Thomas, This got ack from Stephen Hemminger also. It is pending from long time, Can we consider this for RC1 ?
Regards, Rahul > -----Original Message----- > From: Rahul Bhansali > Sent: Wednesday, July 20, 2022 10:22 PM > To: Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org > Cc: Bruce Richardson <bruce.richard...@intel.com>; ferruh.yi...@xilinx.com; > ajit.khapa...@broadcom.com; abo...@pensando.io; > andrew.rybche...@oktetlabs.ru; beilei.x...@intel.com; ch...@att.com; > chenbo....@intel.com; ciara.lof...@intel.com; Devendra Singh Rawat > <dsinghra...@marvell.com>; ed.cz...@atomicrules.com; > evge...@amazon.com; gr...@u256.net; g.si...@nxp.com; > zhouguoy...@huawei.com; haiyue.w...@intel.com; Harman Kalra > <hka...@marvell.com>; heinrich.k...@corigine.com; > hemant.agra...@nxp.com; hyon...@cisco.com; igo...@amazon.com; Igor > Russkikh <irussk...@marvell.com>; jgraj...@cisco.com; > jasvinder.si...@intel.com; jianw...@trustnetic.com; > jiawe...@trustnetic.com; jingjing...@intel.com; johnd...@cisco.com; > john.mil...@atomicrules.com; linvi...@tuxdriver.com; keith.wi...@intel.com; > Kiran Kumar Kokkilagadda <kirankum...@marvell.com>; ouli...@huawei.com; > Liron Himi <lir...@marvell.com>; lon...@microsoft.com; m...@semihalf.com; > spin...@cesnet.cz; ma...@nvidia.com; matt.pet...@windriver.com; > maxime.coque...@redhat.com; m...@semihalf.com; humi...@huawei.com; > Pradeep Kumar Nalla <pna...@marvell.com>; Nithin Kumar Dabilpuram > <ndabilpu...@marvell.com>; qiming.y...@intel.com; qi.z.zh...@intel.com; > Radha Chintakuntla <rad...@marvell.com>; rahul.lakkire...@chelsio.com; > Rasesh Mody <rm...@marvell.com>; rosen...@intel.com; > sachin.sax...@oss.nxp.com; Satha Koteswara Rao Kottidi > <skotesh...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; > shaib...@amazon.com; shepard.sie...@atomicrules.com; > asoma...@amd.com; somnath.ko...@broadcom.com; > sthem...@microsoft.com; steven.webs...@windriver.com; Sunil Kumar Kori > <sk...@marvell.com>; mtetsu...@gmail.com; Veerasenareddy Burru > <vbu...@marvell.com>; viachesl...@nvidia.com; xiao.w.w...@intel.com; > cloud.wangxiao...@huawei.com; yisen.zhu...@huawei.com; > yongw...@vmware.com; xuanziya...@huawei.com > Subject: RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count > > Ping > > > -----Original Message----- > > From: Thomas Monjalon <tho...@monjalon.net> > > Sent: Monday, June 27, 2022 2:42 AM > > To: dev@dpdk.org > > Cc: Bruce Richardson <bruce.richard...@intel.com>; > > ferruh.yi...@xilinx.com; ajit.khapa...@broadcom.com; > > abo...@pensando.io; andrew.rybche...@oktetlabs.ru; > > beilei.x...@intel.com; ch...@att.com; chenbo....@intel.com; > > ciara.lof...@intel.com; Devendra Singh Rawat > > <dsinghra...@marvell.com>; ed.cz...@atomicrules.com; > > evge...@amazon.com; gr...@u256.net; g.si...@nxp.com; > > zhouguoy...@huawei.com; haiyue.w...@intel.com; Harman Kalra > > <hka...@marvell.com>; heinrich.k...@corigine.com; > > hemant.agra...@nxp.com; hyon...@cisco.com; igo...@amazon.com; Igor > > Russkikh <irussk...@marvell.com>; jgraj...@cisco.com; > > jasvinder.si...@intel.com; jianw...@trustnetic.com; > > jiawe...@trustnetic.com; jingjing...@intel.com; johnd...@cisco.com; > > john.mil...@atomicrules.com; linvi...@tuxdriver.com; > > keith.wi...@intel.com; Kiran Kumar Kokkilagadda > > <kirankum...@marvell.com>; ouli...@huawei.com; Liron Himi > > <lir...@marvell.com>; lon...@microsoft.com; m...@semihalf.com; > > spin...@cesnet.cz; ma...@nvidia.com; matt.pet...@windriver.com; > > maxime.coque...@redhat.com; m...@semihalf.com; humi...@huawei.com; > > Pradeep Kumar Nalla <pna...@marvell.com>; Nithin Kumar Dabilpuram > > <ndabilpu...@marvell.com>; qiming.y...@intel.com; > > qi.z.zh...@intel.com; Radha Chintakuntla <rad...@marvell.com>; > > rahul.lakkire...@chelsio.com; Rasesh Mody <rm...@marvell.com>; > > rosen...@intel.com; sachin.sax...@oss.nxp.com; Satha Koteswara Rao > > Kottidi <skotesh...@marvell.com>; Shahed Shaikh > > <shsha...@marvell.com>; shaib...@amazon.com; > > shepard.sie...@atomicrules.com; asoma...@amd.com; > > somnath.ko...@broadcom.com; sthem...@microsoft.com; > > steven.webs...@windriver.com; Sunil Kumar Kori <sk...@marvell.com>; > > mtetsu...@gmail.com; Veerasenareddy Burru <vbu...@marvell.com>; > > viachesl...@nvidia.com; xiao.w.w...@intel.com; > > cloud.wangxiao...@huawei.com; yisen.zhu...@huawei.com; > > yongw...@vmware.com; xuanziya...@huawei.com; Rahul Bhansali > > <rbhans...@marvell.com> > > Subject: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets > > count > > > > External Email > > > > ---------------------------------------------------------------------- > > Please could we have some tests on other hardware with this improvement? > > > > > > 25/05/2022 11:13, Rahul Bhansali: > > > An additional check is added to avoid extra processing if receive > > > packets are 0. > > > > > > Performance impact: with Marvell OCTEON TX2 platform, observed an > > > improvement by ~14%. > > > > > > Signed-off-by: Rahul Bhansali <rbhans...@marvell.com> > > > --- > > > nb_rx = rte_eth_rx_burst(portid, 0, > > > pkts_burst, MAX_PKT_BURST); > > > > > > + if (unlikely(nb_rx == 0)) > > > + continue; > > > + > > > > > >
