<snip> > > > > > > > > > > diff --git a/dts/.editorconfig b/dts/.editorconfig new file mode > > > > > 100644 index 0000000000..657f959030 > > > > > --- /dev/null > > > > > +++ b/dts/.editorconfig > > > > > @@ -0,0 +1,7 @@ > > > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > > > +PANTHEON.tech s.r.o. > > > > > +# See https://editorconfig.org/ for syntax reference. > > > > > +# > > > > > + > > > > > +[*.py] > > > > > +max_line_length = 88 > > > > > > > > It seems strange to have two different editorconfig settings in > > > > DPDK. Is there a reason that: > > > > a) we can't use 79, the current DPDK default and recommended length by > > > > pycodestyle? Or alternatively: > > > > b) change all of DPDK to use the 88 setting? > > > > > > > > Also, 88 seems an unusual number. How was it chosen/arrived at? > > > > > > > > > > The commit message contains a link to Black's documentation where > > > they > > explain it: > > > https://black.readthedocs.io/en/stable/the_black_code_style/current_ > > > st > > > yle.html#line-length > > > > > > Let me know what you think about it. I think it's reasonable. I'll > > > move the > > config to the top level .editorconfig file. > > > > > > > I have no objection to moving this to the top level, but others may > > like to keep our python style as standard. Realistically I see three > > choices here: > > > > 1. Force DTS to conform to existing DPDK python style of 79 characters > > 2. Allow DTS to use 88 chars but the rest of DPDK to keep with 79 > > chars 3. Allow all of DPDK to use 88 chars. > > > > Of the 3, I like relaxing the 79/80 char limit so #3 seems best to me > > as you suggest. However, I'd wait a few days for a desenting opinion > > before I'd do a new patchset revision. :-) +1 for option #3, it seems reasonable
> > > > Ok, I'll wait. > > > /Bruce
