> -----Original Message----- > From: Kundapura, Ganapati <[email protected]> > Sent: Tuesday, September 13, 2022 12:32 PM > To: [email protected]; [email protected] > Cc: Jayatheerthan, Jay <[email protected]>; Naga Harish K, S V > <[email protected]> > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of > rte_event structure is reset which is used by the application
Just a minor comment - application may or may not use this field. "which can be used" is better suited. Rest looks good. Thanks for posting. With this change, Acked-by: Jay Jayatheerthan <[email protected]> > to determine the processing function. > > Removed resetting of rte_event::sub_event_type > > Signed-off-by: Ganapati Kundapura <[email protected]> > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index 64a6add..e42e41c 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter *rx_adapter, > qi_ev->event = ev->event; > qi_ev->op = RTE_EVENT_OP_NEW; > qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > - qi_ev->sub_event_type = 0; > > if (conf->rx_queue_flags & > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { > -- > 2.6.4
