On Sun, Sep 11, 2022 at 06:08:49PM -0700, Nic Chautru wrote:
> From: Nicolas Chautru <nicolas.chau...@intel.com>
>
> This patch introduce stubs for device driver for the ACC200
> integrated VRAN accelerator on SPR-EEC
>
> Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com>
> ---
> MAINTAINERS | 3 +
> doc/guides/bbdevs/acc200.rst | 244
> +++++++++++++++++++++++++++++++
> doc/guides/bbdevs/index.rst | 1 +
> drivers/baseband/acc200/acc200_pmd.h | 32 ++++
> drivers/baseband/acc200/meson.build | 6 +
> drivers/baseband/acc200/rte_acc200_pmd.c | 142 ++++++++++++++++++
> drivers/baseband/acc200/version.map | 3 +
> drivers/baseband/meson.build | 1 +
> 8 files changed, 432 insertions(+)
> create mode 100644 doc/guides/bbdevs/acc200.rst
> create mode 100644 drivers/baseband/acc200/acc200_pmd.h
> create mode 100644 drivers/baseband/acc200/meson.build
> create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c
> create mode 100644 drivers/baseband/acc200/version.map
>
<snip>
> diff --git a/drivers/baseband/acc200/meson.build
> b/drivers/baseband/acc200/meson.build
> new file mode 100644
> index 0000000..7ec8679
> --- /dev/null
> +++ b/drivers/baseband/acc200/meson.build
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2022 Intel Corporation
> +
> +deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci']
> +
Does this really depend on both bus_vdev and bus_pci?
Ideally, I think that drivers/baseband/meson.build should probably have the
line "std_deps = ['bbdev']" to pull in that as a dependency for all
baseband drivers.
Based off some quick testing, I got this driver to build with just
"deps += ['bbdev', 'bus_pci']". Though, again, I think these probably
should be standard deps for all bbdevs.
> +sources = files('rte_acc200_pmd.c')
Given that the driver is using shared headers with the acc100 codebase, you
might want to consider putting in
"includes += include_directories('../acc100')"
in the meson.build file. It saves you having to manually specify the full
path to all these shared headers, and gives you only one place to update
things if those headers ever move elsewhere.
/Bruce
