Test fail.
Nacked-by: Qiming Yang <qiming.y...@intel.com>
> -----Original Message-----
> From: Zhang, Peng1X <peng1x.zh...@intel.com>
> Sent: Thursday, September 1, 2022 5:33 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.y...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>; Zhang, Peng1X <peng1x.zh...@intel.com>
> Subject: [PATCH v2] net/iavf: enable inner and outer Tx checksum offload
>
> Enable inner and outer Tx checksum offload for tunnel packet by configure
> ol_flags.
>
> Signed-off-by: Peng Zhang <peng1x.zh...@intel.com>
>
> ---
> v2: add outer udp cksum flag and remove unrelated code
> ---
> drivers/net/iavf/iavf_ethdev.c | 1 +
> drivers/net/iavf/iavf_rxtx.c | 48 ++++++++++++++++++++++++++++++++--
> drivers/net/iavf/iavf_rxtx.h | 9 ++++++-
> 3 files changed, 55 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 506fcff6e3..fa040766e5 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -1134,6 +1134,7 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> RTE_ETH_TX_OFFLOAD_TCP_TSO |
> RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index
> 3deabe1d7e..b784c5cc18 100644
> --- a/drivers/net/iavf/iavf_rxtx.c
> +++ b/drivers/net/iavf/iavf_rxtx.c
> @@ -2334,7 +2334,8 @@ static inline uint16_t
> iavf_calc_context_desc(uint64_t flags, uint8_t vlan_flag) {
> if (flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG |
> - RTE_MBUF_F_TX_TUNNEL_MASK))
> + RTE_MBUF_F_TX_TUNNEL_MASK |
> RTE_MBUF_F_TX_OUTER_IP_CKSUM |
> + RTE_MBUF_F_TX_OUTER_UDP_CKSUM))
> return 1;
> if (flags & RTE_MBUF_F_TX_VLAN &&
> vlan_flag & IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2)
> @@ -2399,6 +2400,44 @@ iavf_fill_ctx_desc_tunnelling_field(volatile
> uint64_t *qw0,
> break;
> }
>
> + /* L4TUNT: L4 Tunneling Type */
> + switch (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) {
> + case RTE_MBUF_F_TX_TUNNEL_IPIP:
> + /* for non UDP / GRE tunneling, set to 00b */
> + break;
> + case RTE_MBUF_F_TX_TUNNEL_VXLAN:
> + case RTE_MBUF_F_TX_TUNNEL_GTP:
> + case RTE_MBUF_F_TX_TUNNEL_GENEVE:
> + eip_typ |= IAVF_TXD_CTX_UDP_TUNNELING;
> + break;
> + case RTE_MBUF_F_TX_TUNNEL_GRE:
> + eip_typ |= IAVF_TXD_CTX_GRE_TUNNELING;
> + break;
> + default:
> + PMD_TX_LOG(ERR, "Tunnel type not supported");
> + return;
> + }
> +
> + /* L4TUNLEN: L4 Tunneling Length, in Words
> + *
> + * We depend on app to set rte_mbuf.l2_len correctly.
> + * For IP in GRE it should be set to the length of the GRE
> + * header;
> + * For MAC in GRE or MAC in UDP it should be set to the length
> + * of the GRE or UDP headers plus the inner MAC up to including
> + * its last Ethertype.
> + * If MPLS labels exists, it should include them as well.
> + */
> + eip_typ |= (m->l2_len >> 1) << IAVF_TXD_CTX_QW0_NATLEN_SHIFT;
> +
> + /**
> + * Calculate the tunneling UDP checksum.
> + * Shall be set only if L4TUNT = 01b and EIPT is not zero
> + */
> + if (!(eip_typ & IAVF_TX_CTX_EXT_IP_NONE) &&
> + (eip_typ & IAVF_TXD_CTX_UDP_TUNNELING))
> + eip_typ |= IAVF_TXD_CTX_QW0_L4T_CS_MASK;
> +
> *qw0 = eip_typ << IAVF_TXD_CTX_QW0_TUN_PARAMS_EIPT_SHIFT |
> eip_len <<
> IAVF_TXD_CTX_QW0_TUN_PARAMS_EIPLEN_SHIFT |
> eip_noinc <<
> IAVF_TXD_CTX_QW0_TUN_PARAMS_EIP_NOINC_SHIFT;
> @@ -2535,7 +2574,12 @@ iavf_build_data_desc_cmd_offset_fields(volatile
> uint64_t *qw1,
> }
>
> /* Set MACLEN */
> - offset |= (m->l2_len >> 1) << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
> + if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)
> + offset |= (m->outer_l2_len >> 1)
> + << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
> + else
> + offset |= (m->l2_len >> 1)
> + << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
>
> /* Enable L3 checksum offloading inner */
> if (m->ol_flags & RTE_MBUF_F_TX_IP_CKSUM) { diff --git
> a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index
> 1695e43cd5..66e832713c 100644
> --- a/drivers/net/iavf/iavf_rxtx.h
> +++ b/drivers/net/iavf/iavf_rxtx.h
> @@ -26,6 +26,8 @@
> #define IAVF_TX_NO_VECTOR_FLAGS ( \
> RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
> RTE_ETH_TX_OFFLOAD_TCP_TSO | \
> + RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | \
> + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | \
> RTE_ETH_TX_OFFLOAD_SECURITY)
>
> #define IAVF_TX_VECTOR_OFFLOAD ( \
> @@ -56,7 +58,9 @@
> #define IAVF_TX_CKSUM_OFFLOAD_MASK ( \
> RTE_MBUF_F_TX_IP_CKSUM | \
> RTE_MBUF_F_TX_L4_MASK | \
> - RTE_MBUF_F_TX_TCP_SEG)
> + RTE_MBUF_F_TX_TCP_SEG | \
> + RTE_MBUF_F_TX_OUTER_IP_CKSUM | \
> + RTE_MBUF_F_TX_OUTER_UDP_CKSUM)
>
> #define IAVF_TX_OFFLOAD_MASK ( \
> RTE_MBUF_F_TX_OUTER_IPV6 | \
> @@ -67,6 +71,9 @@
> RTE_MBUF_F_TX_IP_CKSUM | \
> RTE_MBUF_F_TX_L4_MASK | \
> RTE_MBUF_F_TX_TCP_SEG | \
> + RTE_MBUF_F_TX_TUNNEL_MASK | \
> + RTE_MBUF_F_TX_OUTER_IP_CKSUM | \
> + RTE_MBUF_F_TX_OUTER_UDP_CKSUM | \
> RTE_ETH_TX_OFFLOAD_SECURITY)
>
> #define IAVF_TX_OFFLOAD_NOTSUP_MASK \
> --
> 2.25.1
