On Thu, Sep 1, 2022 at 10:08 AM Mah, Yock Gen <yock.gen....@intel.com> wrote: > > >-----Original Message----- > >From: Zhang, Qi Z <qi.z.zh...@intel.com> > >Sent: Tuesday, 30 August, 2022 7:17 PM > >To: IOTG DPDK Ref App <iotg.dpdk.ref....@intel.com>; dev@dpdk.org > >Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking > > > -----Original Message----- > > From: iotg.dpdk.ref....@intel.com <iotg.dpdk.ref....@intel.com> > > Sent: Monday, August 29, 2022 4:15 PM > > To: dev@dpdk.org > > Subject: [PATCH] IGC: Remove I225_I_PHY_ID checking > > > > From: NSWE SWS DPDK Dev <iotg.dpdk.ref....@intel.com> > > > > i225 devices have only one PHY vendor. There is unnecessary to check > > _I_PHY_ID during the link establishment and auto-negotiation process, > > the checking also caused devices like i225-IT failed. This patch is to > > remove the mentioned unnecessary checking. > > > > Cc: sta...@dpdk.org > > Signed-off-by: NSWE SWS DPDK Dev <iotg.dpdk.ref....@intel.com> > > >Is this the expected author name? > Yes, this is expected author name, the PDL email contain all developers > working on the patch for better support and response.
This is not acceptable. https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body It is clearly stated that: """ The signoff must be a real name and not an alias or nickname. More than one signoff is allowed. """ And all developers involved in the making of a patch must follow the Developer’s Certificate of Origin. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 In its current form, this patch cannot be merged in the DPDK project. Besides, please register to the @dev mailing list. -- David Marchand
