Hi all,
A gentle ping on this patch.
On 2022-08-02 15:55:03 +0800, Chaoyong He wrote:
> From: Peng Zhang <peng.zh...@corigine.com>
>
> During initialization of the NFP driver, a file name for loading
> application firmware is composed using the NIC's AMDA information and port
> type (count and speed). E.g.: "nic_AMDA0145-1012_2x10.nffw".
>
> In practice there may be many variants for each NIC type, and many of the
> variants relate to assembly components which do not concern the driver and
> application firmware implementation. Yet the current scheme leads to a
> different application firmware file name for each variant, because they
> have different AMDA information.
>
> To reduce proliferation of content-duplicated application firmware images
> or symlinks, the NIC's management firmware will only expose differences
> between variants that need different application firmware via a newly
> introduced hwinfo, "nffw.partno".
>
> Use of the existing hwinfo, "assembly.partno", is maintained in order to
> support for NICs with management firmware that does not expose
> "nffw.partno".
>
> Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Peng Zhang <peng.zh...@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong...@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderl...@corigine.com>
> ---
> drivers/net/nfp/nfp_ethdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
> index 5cdd34e588..e9d01f4414 100644
> --- a/drivers/net/nfp/nfp_ethdev.c
> +++ b/drivers/net/nfp/nfp_ethdev.c
> @@ -680,7 +680,9 @@ nfp_fw_setup(struct rte_pci_device *dev,
> char card_desc[100];
> int err = 0;
>
> - nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "assembly.partno");
> + nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "nffw.partno");
> + if (nfp_fw_model == NULL)
> + nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "assembly.partno");
>
> if (nfp_fw_model) {
> PMD_DRV_LOG(INFO, "firmware model found: %s", nfp_fw_model);
> --
> 2.27.0
>
--
Kind Regards,
Niklas Söderlund
