> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 29 August 2022 17.19 > To: dev@dpdk.org > Cc: Bruce Richardson > Subject: [RFC PATCH 1/3] os: begin separating some OS compatibility > from EAL > > Some library functionality we may want ahead of EAL build depends upon > some OS-specific functionality, so we create a new lib for that to be > built separately. For now, just includes fnmatch function for windows.
The description given in patch 0/3 mentions that this causes a circular dependency between the EAL and Log libraries. You should mention that here too. Until I re-read that, I didn't understand the need to move fnmatch() out of the EAL library - I was even sidetracking wildly, considering if it had to do with needing it on the host computer (for some host compiler checks). FYI, and not important: fnmatch() is a C library function (man 3), not a System call (man 2). But obviously still O/S specific, since it is not included with the C library for Windows.