Hi Maxime, > -----Original Message----- > From: Maxime Coquelin <maxime.coque...@redhat.com> > Sent: Friday, August 26, 2022 5:08 AM > To: Chautru, Nicolas <nicolas.chau...@intel.com>; dev@dpdk.org; > tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com > Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce > <bruce.richard...@intel.com>; david.march...@redhat.com; > step...@networkplumber.org > Subject: Re: [PATCH v6 5/7] bbdev: add new operation for FFT processing > > > > On 8/25/22 20:24, Nicolas Chautru wrote: > > Extension of bbdev operation to support FFT based operations. > > > > Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com> > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com> > > --- > > doc/guides/prog_guide/bbdev.rst | 130 > +++++++++++++++++++++++++++++++++++ > > lib/bbdev/rte_bbdev.c | 10 ++- > > lib/bbdev/rte_bbdev.h | 76 ++++++++++++++++++++ > > lib/bbdev/rte_bbdev_op.h | 149 > ++++++++++++++++++++++++++++++++++++++++ > > lib/bbdev/version.map | 4 ++ > > 5 files changed, 368 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/prog_guide/bbdev.rst > > b/doc/guides/prog_guide/bbdev.rst index 70fa01a..150161b 100644 > > --- a/doc/guides/prog_guide/bbdev.rst > > +++ b/doc/guides/prog_guide/bbdev.rst > > @@ -1118,6 +1118,136 @@ Figure :numref:`figure_turbo_tb_decode` above > > showing the Turbo decoding of CBs using BBDEV interface in TB-mode > > is also valid for LDPC decode. > > > > +BBDEV FFT Operation > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +This operation allows to run a combination of DFT and/or IDFT and/or time- > domain windowing. > > +These can be used in a modular fashion (using bypass modes) or as a > > +processing pipeline which can be used for FFT-based baseband signal > processing. > > +In more details it allows : > > +- to process the data first through an IDFT of adjustable size and > > +padding; > > +- to perform the windowing as a programmable cyclic shift offset of > > +the data followed by a pointwise multiplication by a time domain > > +window; > > +- to process the related data through a DFT of adjustable size and > > +depadding for each such cyclic > > depadding?
This is the opposite processing of padding bits to the buffer (take out such bits either leading or trailing). From googling around, this is more often written as "de-padding" so will correct. > > > +shift output. > > + > > +A flexible number of Rx antennas are being processed in parallel with the > same configuration. > > +The API allows more generally for flexibility in what the PMD may > > +support (cabability flags) and > > s/cabability/capability/ > Thanks! I will fix now > With above typos fixed: > Acked-by: Maxime Coquelin <maxime.coque...@redhat.com> > > Thanks, > Maxime
