On 8/23/2022 9:41 AM, David Marchand wrote:
On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko
<andrew.rybche...@oktetlabs.ru> wrote:

Remove deprecated because of invalid namespace defines.

Andrew Rybchenko (10):
   ethdev: remove deprecated link speed and duplex defines
   ethdev: remove deprecated Rx and Tx multi-queue mode defines
   ethdev: remove deprecated defines for RSS configuration
   ethdev: remove deprecated Rx and Tx offload defines
   ethdev: remove deprecated DCB and VMDq defines
   ethdev: remove deprecated tunnel type defines
   ethdev: remove deprecated flow control defines
   ethdev: remove deprecated VLAN offload configuration defines
   ethdev: remove deprecated maximum Rx MAC addresses define
   ethdev: remove deprecated metadata dynamic fields defines


Same comment as for the mbuf flags patch, we have a cocci script to do
the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci
We can reference it in the release notes.


Agreed. I will group release notes updates while merging. And note 'devtools/cocci/namespace_ethdev.cocci'.

I suspect the RN will grow quite big for 22.11.
Can we perhaps have a single entry for ethdev, listing all the
different defines in a sublist?

I am also not sure about benefit of the multiple commits, I will keep as it is since it is already split. But maybe can be squashed while pulling from next-net.

(and looking again at the other cleanups, this last comment applies to
the mempool series too).


I sent some comments, but otherwise, the series lgtm and you can add my ack.

Adding your explicit ack while merging:
Acked-by: David Marchand <david.march...@redhat.com>

For series,
Acked-by: Ferruh Yigit <ferruh.yi...@xilinx.com>

Series applied to dpdk-next-net/main, thanks.

Reply via email to