Bugzilla ID: 296
the size of counters array in mlx5_xstats_get() was smaller
than the memory we are setting for this array in
mlx5_os_read_dev_counters(). due to which the extra memory is
corrupted and thus corrupting the seemingly unrelated variables.
this happens at the first run only because the n function arg
of mlx5_xstats_get() which is used to init counters array is
initialized by adding the preceding statistics which in our case
(i.e first run) is zero. after the initialization in
mlx5_os_stats_init() the mlx5_stats_n is populated and thus from
then onward the counters array size is correct
my changes will only affect the flow of the first run when we
need to initialize stats in mlx5_os_stats_init(). the size of the
counters array is set according the mlx5_stats_n variable. by doing
this we will avoid the memset corrupting other variables` memory
Signed-off-by: huzaifa.rahman <huzaifa.rah...@emumba.com>
---
drivers/net/mlx5/mlx5_stats.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
index f64fa3587b..bccfec10fb 100644
--- a/drivers/net/mlx5/mlx5_stats.c
+++ b/drivers/net/mlx5/mlx5_stats.c
@@ -40,7 +40,6 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat
*stats,
{
struct mlx5_priv *priv = dev->data->dev_private;
unsigned int i;
- uint64_t counters[n];
struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
uint16_t mlx5_stats_n = xstats_ctrl->mlx5_stats_n;
@@ -51,8 +50,11 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct
rte_eth_xstat *stats,
stats_n = mlx5_os_get_stats_n(dev);
if (stats_n < 0)
return stats_n;
- if (xstats_ctrl->stats_n != stats_n)
+ if (xstats_ctrl->stats_n != stats_n) {
mlx5_os_stats_init(dev);
+ n = xstats_ctrl->mlx5_stats_n;
+ }
+ uint64_t counters[n];
ret = mlx5_os_read_dev_counters(dev, counters);
if (ret)
return ret;
--
2.25.1
