> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Wednesday, August 3, 2022 23:12
> To: Guo, Junfeng <junfeng....@intel.com>
> Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>;
> dev@dpdk.org; Li, Xiaoyun <xiaoyun...@intel.com>; Wang, Xiao W
> <xiao.w.w...@intel.com>
> Subject: Re: [PATCH 03/13] net/idpf: support device initialization
>
> On Wed, 3 Aug 2022 19:30:54 +0800
> Junfeng Guo <junfeng....@intel.com> wrote:
>
> > +
> > +static int
> > +idpf_dev_configure(struct rte_eth_dev *dev)
> > +{
> > + struct idpf_vport *vport =
> > + (struct idpf_vport *)dev->data->dev_private;
>
> Cast of void pointer dev_private is unnecessary in C (only in C++ is it
> needed).
>
> > + int ret = 0;
>
> Useless initialization, you are setting in next line.
Thanks for your review! Will refine this in the patchset of upcoming version.
>
> > +
> > + ret = idpf_init_vport_req_info(dev);
> > + if (ret) {
