On Mon, May 18, 2015 at 9:06 AM, Xie, Huawei <huawei.xie at intel.com> wrote:
> On 5/7/2015 9:17 PM, Pavel Boldin wrote: > > > On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei <huawei.xie at intel.com<mailto: > huawei.xie at intel.com>> wrote: > On 4/3/2015 1:02 AM, Pavel Boldin wrote: > > Move ioctl `EVENTFD_COPY' handler code to an inline function. > Pavel: > There is no necessity to inline this function. > Xie, there is even no necessity to split this in a five piece patchseries. > I did that solely for the purpose of clean reading. > > There is no necessity to inline any single-used functions as long the > compiler is decent. But I prefer to instruct compiler to do this explictly > so there is no call/ret path in the generated code. > > The purpose of inline or not is not for friendly reading. inline is for > performance only. > Well, an optimizing compiler `inline's all the `static' functions that are called only once in the file. So, this `inline' is purely for readability of the code. This makes user aware that the function will be `inline'd anyway. Pavel > > > > /huawei > > >
