Add in some basic unit tests to validate the character escaping being
done on string data values, which tests end-to-end processing of those
values beyond just the json-encoding steps tested by the
"telemetry_json_autotest".

Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
---
 app/test/test_telemetry_data.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c
index 5a85e790d3..cfa4d636f0 100644
--- a/app/test/test_telemetry_data.c
+++ b/app/test/test_telemetry_data.c
@@ -347,6 +347,30 @@ test_array_with_array_u64_values(void)
        return CHECK_OUTPUT("[[0,1,2,3,4],[0,1,2,3,4]]");
 }
 
+static int
+test_string_char_escaping(void)
+{
+       rte_tel_data_string(&response_data, "hello,\nworld\n");
+       return CHECK_OUTPUT("\"hello,\\nworld\\n\"");
+}
+
+static int
+test_array_char_escaping(void)
+{
+       rte_tel_data_start_array(&response_data, RTE_TEL_STRING_VAL);
+       rte_tel_data_add_array_string(&response_data, "\\escape\r");
+       rte_tel_data_add_array_string(&response_data, "characters\n");
+       return CHECK_OUTPUT("[\"\\\\escape\\r\",\"characters\\n\"]");
+}
+
+static int
+test_dict_char_escaping(void)
+{
+       rte_tel_data_start_dict(&response_data);
+       rte_tel_data_add_dict_string(&response_data, "name", 
"escaped\n\tvalue");
+       return CHECK_OUTPUT("{\"name\":\"escaped\\n\\tvalue\"}");
+}
+
 static int
 connect_to_socket(void)
 {
@@ -406,7 +430,11 @@ telemetry_data_autotest(void)
                        test_dict_with_dict_values,
                        test_array_with_array_int_values,
                        test_array_with_array_u64_values,
-                       test_array_with_array_string_values };
+                       test_array_with_array_string_values,
+                       test_string_char_escaping,
+                       test_array_char_escaping,
+                       test_dict_char_escaping,
+       };
 
        rte_telemetry_register_cmd(REQUEST_CMD, telemetry_test_cb, "Test");
        for (i = 0; i < RTE_DIM(test_cases); i++) {
-- 
2.34.1

Reply via email to