> -----Original Message-----
> From: Kearney, Tadhg <tadhg.kear...@intel.com>
> diff --git a/config/x86/meson.build b/config/x86/meson.build index
> +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1)
> +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32)
Check if these flags should be added to other platforms.
<snip>
> +Abstract
> +~~~~~~~~
> +Up to 60% power saving can be achieved by reducing the uncore frequency
> to its lowest value.
Might be give some intro on this before specifying directly the power saving.
Would be good to say power savings achieved instead of specific with any %.
Also
> +With later kernels, there is now a sysfs entry to allow adjustment of uncore
> frequency.
Kernel provides the driver "intel-uncore-frequency to control the uncore
frequency limits for x86 platform. The driver is available from the kernel
version 5.6 and above.
> diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c
> +static int
> +set_uncore_freq_internal(struct uncore_power_info *ui, uint32_t idx) {
<snip>
> + open_core_sysfs_file(&ui->f_cur_max, "rw+",
> POWER_UNCORE_SYSFILE_MAX_FREQ,
You have already this f_cur_max opened , you can re-use, instead of opening
again.
Thanks,
Reshma
