Hi Kai, Will fix the is duplication of OPENSSL_VERSION_NUMBER check.
Some CMAC tests are already present. The number of successful tests in cryptodev_openssl_autotest increases by 4 with this change. I am not planning to add more. Regards, Ashwin Sekhar T K > -----Original Message----- > From: Ji, Kai <kai...@intel.com> > Sent: Monday, July 18, 2022 7:27 PM > To: Ashwin Sekhar Thalakalath Kottilveetil <asek...@marvell.com> > Cc: Anoob Joseph <ano...@marvell.com>; dev@dpdk.org; Akhil Goyal > <gak...@marvell.com>; Harman Kalra <hka...@marvell.com>; Jerin Jacob > Kollanukkaran <jer...@marvell.com>; Kiran Kumar Kokkilagadda > <kirankum...@marvell.com>; Nithin Kumar Dabilpuram > <ndabilpu...@marvell.com>; Pavan Nikhilesh Bhagavatula > <pbhagavat...@marvell.com>; Satheesh Paul Antonysamy > <psathe...@marvell.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>; > Sunil Kumar Kori <sk...@marvell.com>; Satha Koteswara Rao Kottidi > <skotesh...@marvell.com> > Subject: [EXT] RE: [PATCH v4 0/1] crypto/openssl: add aes cmac support > > External Email > > ---------------------------------------------------------------------- > Hi Ashwin, > > There is duplication of OPENSSL_VERSION_NUMBER check in v4, right > before process_openssl_auth_mac(). > Are you planning to enable CMAC unit test case in > cryptodev_openssl_autotest ? > > Regards > > Kai > > > > -----Original Message----- > > From: Ashwin Sekhar T K <asek...@marvell.com> > > Sent: Monday, July 18, 2022 10:19 AM > > To: asek...@marvell.com > > Cc: ano...@marvell.com; dev@dpdk.org; gak...@marvell.com; > > hka...@marvell.com; jer...@marvell.com; kirankum...@marvell.com; > > ndabilpu...@marvell.com; pbhagavat...@marvell.com; > > psathe...@marvell.com; Zhang, Roy Fan <roy.fan.zh...@intel.com>; > > sk...@marvell.com; skotesh...@marvell.com > > Subject: [PATCH v4 0/1] crypto/openssl: add aes cmac support > > > > Add support for aes cmac operations. > > > > v2: > > * Added support for openssl 3.0 > > v3: > > * Fixed checkpatch warnings. > > v4: > > * Fixed more checkpatch warnings. > > > > Ashwin Sekhar T K (1): > > crypto/openssl: support aes cmac operations > > > > drivers/crypto/openssl/openssl_pmd_private.h | 14 ++ > > drivers/crypto/openssl/rte_openssl_pmd.c | 142 > ++++++++++++++++++- > > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 20 +++ > > 3 files changed, 169 insertions(+), 7 deletions(-) > > > > -- > > 2.25.1
