Hi David, > -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Sunday, July 10, 2022 2:18 PM > To: dev@dpdk.org; techbo...@dpdk.org > Cc: Ray Kinsella <m...@ashroe.eu> > Subject: [PATCH] doc: announce marking device and driver objects as > internal > > rte_driver and rte_device are unnecessarily exposed in the public API/ABI. > Announce that they will be made opaque in the public API and mark > associated API as internal. > This impacts all bus, as their driver registration mechanism will be > made internal. > > Note: the PCI bus had a similar deprecation notice that we can remove as > the new one is more generic. > > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > doc/guides/rel_notes/deprecation.rst | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index a9fd6676be..b9cc267b30 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -38,6 +38,13 @@ Deprecation Notices > external users may still register their bus using a new driver header > (see > ``enable_driver_sdk`` meson option). > > +* drivers: As a followup on the work on the ``rte_bus`` object, the > + ``rte_driver`` and ``rte_device`` objects (and as a domino effect, > their > + bus-specific counterparts) will be made opaque in DPDK 22.11. > + Registering a driver on a bus will be marked as an internal API: > + external users may still register their drivers using the bus specific > + driver header (see ``enable_driver_sdk`` meson option). > +
Cc SPDK folks Thanks for your work! My only concern is using enable_driver_sdk may not be a good way for SPDK based on the discussion. http://patchwork.dpdk.org/project/dpdk/cover/20210918022443.12719-1-chenbo....@intel.com/ But overall this idea makes sense, so: Acked-by: Chenbo Xia <chenbo....@intel.com> > * mempool: Helper macro ``MEMPOOL_HEADER_SIZE()`` is deprecated and will > be removed in DPDK 22.11. The replacement macro > ``RTE_MEMPOOL_HEADER_SIZE()`` is internal only. > @@ -49,11 +56,6 @@ Deprecation Notices > * mempool: The mempool API macros ``MEMPOOL_PG_*`` are deprecated and > will be removed in DPDK 22.11. > > -* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, > "rte_bus_pci.h" > - will be made internal in 21.11 and macros/data structures/functions > defined > - in the header will not be considered as ABI anymore. This change is > inspired > - by the RFC https://patchwork.dpdk.org/project/dpdk/list/?series=17176. > - > * lib: will fix extending some enum/define breaking the ABI. There are > multiple > samples in DPDK that enum/define terminated with a ``.*MAX.*`` value > which is > used by iterators, and arrays holding these values are sized with this > -- > 2.36.1
