Hi, On 05/13/2015 06:35 PM, Keith Wiles wrote: > Simplify the ifdefs in rte.app.mk to make the code more > readable and maintainable by introducing a internal > _LDLIBS-y variable to build up the LDLIBS variable. > > The new internal variable _LDLIBS-y should not be > used outside of the rte.app.mk file. > > Signed-off-by: Keith Wiles <keith.wiles at intel.com> > --- > mk/rte.app.mk | 243 > +++++++++++++++------------------------------------------- > 1 file changed, 61 insertions(+), 182 deletions(-) > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index af8a1b0..1a2043a 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > [...] > > -LDLIBS += $(CPU_LDLIBS) > +LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) > > .PHONY: all > all: install
You are still adding EXTRA_LDLIBS in a patch called "simplify the ifdefs". A good idea before sending a new version of a patch on the mailing list is to check the list of the modifications that were discussed. Then this list can be added in the cover letter or after the "---" marker of your patch, allowing the reviewers to better understand what changed in this version. Regards, Olivier
