> Subject: Re: [PATCH 01/17] net/mana: add basic driver, build environment and > doc > > On Fri, 1 Jul 2022 02:02:31 -0700 > lon...@linuxonhyperv.com wrote: > > > diff --git a/drivers/net/mana/meson.build > > b/drivers/net/mana/meson.build new file mode 100644 index > > 0000000000..7ab34c253c > > --- /dev/null > > +++ b/drivers/net/mana/meson.build > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 Microsoft > > +Corporation > > + > > +if is_windows > > + build = false > > + reason = 'not supported on Windows' > > + subdir_done() > > +endif > > Since the driver is listed as only supported on x86, probably best to enforce > that > in meson build as well.
Thank you, I'm sending v2 to address all the comments. Long