> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.z...@intel.com>
> Sent: Tuesday, June 28, 2022 2:21 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming <qiming.y...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>; Zeng, ZhichaoX <zhichaox.z...@intel.com>;
> alvinx.zh...@intel.com; Guo, Junfeng <junfeng....@intel.com>; Su, Simei
> <simei...@intel.com>; Ferruh Yigit <ferruh.yi...@intel.com>
> Subject: [PATCH v3] net/igc: move the initialization of data path into
> dev_init
>
> From: Zhichao Zeng <zhichaox.z...@intel.com>
>
> The upper-layer application usually call the common interface "dev_init"
> to initialize the data path, but in the igc driver, the initialization of
> data path is in
> "igc_rx_init" and "eth_igc_tx_queue_setup", while in other drivers it is in
> "dev_init". So when upper-layer application calling these function pointers
> will
> occur segmentation faults.
NO, for most intel PMD e.g.: i40e and ice, we don't initialize data path in
dev_init.
>
> This patch moves the initialization of data path into "eth_igc_dev_init"
> to avoid segmentation faults, which is consistent with other drivers.
I saw dev->rx_pkt_burst can be overwritten in igc_rx_init, I assume the issue
still be exist.
