Re: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed

[Maxime Coquelin]

On 6/22/22 10:46, Thomas Monjalon wrote:

22/06/2022 10:11, Maxime Coquelin:

--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
@@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv

*priv)

                rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
        if (priv->err_intr_handle == NULL) {
                DRV_LOG(ERR, "Fail to allocate intr_handle");
+             rte_errno = ENOMEM;

Shouldn't rte_intr_instance_alloc set it?

I think it makes sense, Thomas could you drop the patch while pulling my
branch? Or do you prefer I remove it directly from my tree?

I'll drop it, no problem.

Thanks, I'll update its patchwork status to change requested

Maxime