> From: Bruce Richardson <bruce.richard...@intel.com>
> Sent: Friday, June 17, 2022 6:53 PM
> [...]
> > +    if owner:
> > +        uid, gid = owner.split(':', maxsplit=1)
> > +        cmd += ' -o uid={},gid={}'.format(uid, gid)
> 
> I'm not sure about forcing the user to always provide a "user:group"
> format parameter. How about:
> 
> 1. checking initially for the presence of a ":" and if not present
>    just working with the uid parameter?
> 2. alternatively, what about adding in separate parameters for user or
>    group, so they can be specified independently?

Explicit is better than implicit, especially in security configuration.
If you insist on changing, I prefer option 2
to clearly indicate what is configured and what is not.

Reply via email to