> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Wednesday, 15 June 2022 09.39 > > Use 'strict=False' in json-loads, it will ignore control characters > (e.g. '\n\t'), this patch is prepared for the support of telemetry dump > in the future. > > Signed-off-by: Chengwen Feng <fengcheng...@huawei.com> > --- > usertools/dpdk-telemetry.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py > index a81868a547..63f8004566 100755 > --- a/usertools/dpdk-telemetry.py > +++ b/usertools/dpdk-telemetry.py > @@ -27,7 +27,7 @@ def read_socket(sock, buf_len, echo=True): > """ Read data from socket and return it in JSON format """ > reply = sock.recv(buf_len).decode() > try: > - ret = json.loads(reply) > + ret = json.loads(reply, strict=False) > except json.JSONDecodeError: > print("Error in reply: ", reply) > sock.close() > -- > 2.33.0 >
As I understand this patch, it accepts non-JSON data from the telemetry socket. Isn't it is a major protocol violation if the telemetry socket produces output requiring this modification? Doing that would break other applications expecting strictly JSON formatted output from the telemetry socket.
