Hi > -----Original Message----- > From: Zhang, Qi Z <qi.z.zh...@intel.com> > Sent: Tuesday, June 14, 2022 00:38 > To: Li, Xiaoyun <xiaoyun...@intel.com>; Loftus, Ciara > <ciara.lof...@intel.com>; dev@dpdk.org > Subject: RE: [PATCH] net/af_xdp: allow using copy mode in XSK > > > > > -----Original Message----- > > From: Li, Xiaoyun <xiaoyun...@intel.com> > > Sent: Monday, June 13, 2022 11:13 PM > > To: Loftus, Ciara <ciara.lof...@intel.com>; Zhang, Qi Z > > <qi.z.zh...@intel.com>; dev@dpdk.org > > Cc: Li, Xiaoyun <xiaoyun...@intel.com> > > Subject: [PATCH] net/af_xdp: allow using copy mode in XSK > > > > DPDK assumes that users only want AF_XDP socket (XSK) into zero copy > > mode when the kernel supports it. However, sometimes kernel driver > > doesn't support it well and copy mode is more stable and preferred. > > rename "no_zerocopy" to "force_copy" looks better? > > This aligned with the comment on the macro definition in kernel > > #define XDP_COPY (1 << 1) /* Force copy-mode */ > > And also make the below code more smooth. > > if (internals->force_copy) > cfg.bind_flags |= XDP_COPY;
Sounds good. Thanks. Will do in the next version. > >
