- Reduced number of comments in asymmetric xform.
Information describing basic functionality of well known
algorithms are unnecessary.
- Added information about data memory lifetime.
It was specified how user should work with private data,
and it is user's responsability to clear it.
- Removed NONE asymetric xform.
Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com>
---
lib/cryptodev/rte_crypto_asym.h | 45 +++++++++++++----------------------------
lib/cryptodev/rte_cryptodev.c | 1 -
2 files changed, 14 insertions(+), 32 deletions(-)
diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index a474b6acd1..0251e8caae 100644
--- a/lib/cryptodev/rte_crypto_asym.h
+++ b/lib/cryptodev/rte_crypto_asym.h
@@ -55,46 +55,29 @@ enum rte_crypto_curve_id {
};
/**
- * Asymmetric crypto transformation types.
- * Each xform type maps to one asymmetric algorithm
- * performing specific operation
- *
+ * Asymmetric crypto algorithm static data.
+ * Data that may be used more than once (e.g. RSA private key).
+ * It is the USER responsibility to keep track of private data memory
+ * lifetime and security of the this data in xform. The same way
+ * it is the USER responsibility to call cryptodev session_clear()
+ * function if a session was created. If session-less not used
+ * xform data should be cleared after successful session creation.
*/
enum rte_crypto_asym_xform_type {
- RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED = 0,
+ RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED,
/**< Invalid xform. */
- RTE_CRYPTO_ASYM_XFORM_NONE,
- /**< Xform type None.
- * May be supported by PMD to support
- * passthrough op for debugging purpose.
- * if xform_type none , op_type is disregarded.
- */
RTE_CRYPTO_ASYM_XFORM_RSA,
- /**< RSA. Performs Encrypt, Decrypt, Sign and Verify.
- * Refer to rte_crypto_asym_op_type
- */
+ /**< RSA */
RTE_CRYPTO_ASYM_XFORM_DH,
- /**< Diffie-Hellman.
- * Performs Key Generate and Shared Secret Compute.
- * Refer to rte_crypto_asym_op_type
- */
+ /**< Diffie-Hellman */
RTE_CRYPTO_ASYM_XFORM_DSA,
- /**< Digital Signature Algorithm
- * Performs Signature Generation and Verification.
- * Refer to rte_crypto_asym_op_type
- */
+ /**< Digital Signature Algorithm */
RTE_CRYPTO_ASYM_XFORM_MODINV,
- /**< Modular Multiplicative Inverse
- * Perform Modular Multiplicative Inverse b^(-1) mod n
- */
+ /**< Modular Multiplicative Inverse */
RTE_CRYPTO_ASYM_XFORM_MODEX,
- /**< Modular Exponentiation
- * Perform Modular Exponentiation b^e mod n
- */
+ /**< Modular Exponentiation */
RTE_CRYPTO_ASYM_XFORM_ECDSA,
- /**< Elliptic Curve Digital Signature Algorithm
- * Perform Signature Generation and Verification.
- */
+ /**< Elliptic Curve Digital Signature Algorithm */
RTE_CRYPTO_ASYM_XFORM_ECPM
/**< Elliptic Curve Point Multiplication */
};
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index e16e6802aa..691625bd04 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -160,7 +160,6 @@ rte_crypto_aead_operation_strings[] = {
* Asymmetric crypto transform operation strings identifiers.
*/
const char *rte_crypto_asym_xform_strings[] = {
- [RTE_CRYPTO_ASYM_XFORM_NONE] = "none",
[RTE_CRYPTO_ASYM_XFORM_RSA] = "rsa",
[RTE_CRYPTO_ASYM_XFORM_MODEX] = "modexp",
[RTE_CRYPTO_ASYM_XFORM_MODINV] = "modinv",
--
2.13.6
