RE: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding"

[Xia, Chenbo]

+ testpmd maintainers

> -----Original Message-----
> From: Maxime Coquelin <maxime.coque...@redhat.com>
> Sent: Thursday, May 5, 2022 6:27 PM
> To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo <chenbo....@intel.com>;
> david.march...@redhat.com; olivier.m...@6wind.com
> Cc: sta...@dpdk.org; Maxime Coquelin <maxime.coque...@redhat.com>
> Subject: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding"
> 
> This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum
> forwarding"),
> as the checksum forwarding is expected to only perform
> checksum and not also overwritte the source and destination

overwrites

> MAC addresses.
> 
> Doing so, we can test checksum offloading with real traffic
> without breaking broadcast packets.
> 
> Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding")
> Cc: sta...@dpdk.org

With above fixed:

Acked-by: Chenbo Xia <chenbo....@intel.com>

> 
> Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
> ---
>  app/test-pmd/csumonly.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index cdb1920763..8b6665d6f3 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -894,10 +894,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
>                * and inner headers */
> 
>               eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
> -             rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
> -                             &eth_hdr->dst_addr);
> -             rte_ether_addr_copy(&ports[fs->tx_port].eth_addr,
> -                             &eth_hdr->src_addr);
>               parse_ethernet(eth_hdr, &info);
>               l3_hdr = (char *)eth_hdr + info.l2_len;
> 
> --
> 2.35.1