10/05/2022 14:11, Tom Rix: > On 5/9/22 2:45 PM, Chautru, Nicolas wrote: > > From: Tom Rix <t...@redhat.com> > >> On 4/27/22 11:17 AM, Nicolas Chautru wrote: > >>> Catch exception in PMD in case of invalid input parameter. > >> It is not clear if this is 1 fix or 2. > >> > >> But it does look like an acc100 fix so it should be split from the > >> acc101 patchset. > >> > > What is the concern? This is a different commit related to acc100. > > Bisecting patchsets. > > A patchset like this that enables a new device should just enable the > new device. > > Not enable a new device and random other stuff. > > If the patchset had to be reverted, the revert would wipe out the fixes. > > That work is done by someone else without deep knowledge or time to > analyze every patchset for misc parts. > > The fixes are more important than the new device, so they should be > submitted first.
Well explained, and I agree with Tom.
