Re: [PATCH 4/8] vmxnet3: add get hw version api

[Andrew Rybchenko]

hw -> HW

However, the API says that it is a firmware version get

Consier:
net/vmxnet3: report HW version on FW version get

On 5/3/22 07:22, Pankaj Gupta wrote:

Implement fw_version_get API for vmxnet3

fw -> FW

"for vmxnet3" is a duplicate, since summary already says so.

Tested, using testpmd, for different hardware version on
ESXi 7.0 Update 2.

Signed-off-by: Pankaj Gupta <pagu...@vmware.com>
---
  drivers/net/vmxnet3/vmxnet3_ethdev.c | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c 
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index a76796716b..f77399f145 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -103,6 +103,10 @@ static int
  vmxnet3_rss_reta_query(struct rte_eth_dev *dev,
                       struct rte_eth_rss_reta_entry64 *reta_conf,
                       uint16_t reta_size);
+static int
+vmxnet3_hw_ver_get(struct rte_eth_dev *dev,
+                  char *fw_version, size_t fw_size);
+
  static int vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev,
                                                uint16_t queue_id);
  static int vmxnet3_dev_rx_queue_intr_disable(struct rte_eth_dev *dev,
@@ -147,6 +151,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
        .rx_queue_intr_disable = vmxnet3_dev_rx_queue_intr_disable,
        .reta_update          = vmxnet3_rss_reta_update,
        .reta_query           = vmxnet3_rss_reta_query,
+       .fw_version_get       = vmxnet3_hw_ver_get,

In general, addition order does not matter and it is
recommended to follow order in eth_dev_ops here (and
where functions are declared, and where functions are
defined).

  };

struct vmxnet3_xstats_name_off {

@@ -1764,3 +1769,19 @@ vmxnet3_rss_reta_query(struct rte_eth_dev *dev,

return 0;

  }
+
+static int
+vmxnet3_hw_ver_get(struct rte_eth_dev *dev,
+                  char *fw_version, size_t fw_size)
+{
+       int ret;
+       struct vmxnet3_hw *hw = dev->data->dev_private;
+
+       ret = snprintf(fw_version, fw_size, "v%d", hw->version);
+
+       ret += 1; /* add the size of '\0' */
+       if (fw_size < (uint32_t)ret)
+               return ret;
+       else
+               return 0;
+}