> -----Original Message----- > From: Pavan Nikhilesh <pbhagavat...@marvell.com> > Sent: Friday, April 29, 2022 9:17 AM > To: ruifeng.w...@arm.com; Wang, Yipeng1 <yipeng1.w...@intel.com>; > Gobriel, Sameh <sameh.gobr...@intel.com>; Richardson, Bruce > <bruce.richard...@intel.com>; Medvedkin, Vladimir > <vladimir.medved...@intel.com> > Cc: jer...@marvell.com; dev@dpdk.org; Pavan Nikhilesh > <pbhagavat...@marvell.com> > Subject: [PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics > > Split x86 and SW hash crc intrinsics into a separate files. > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > --- > v8 Changes: > - Install arch specific headers as indirect headers. > - Retain `rte` prefix for arch specific headers. > v7 Changes: > - Fix build with ppc and other arch. > v6 Changes: > - Simplify rte_hash_crc_set_alg function. (Ruifeng) > v5 Changes: > - Move CRC functions to implementation specific files to remove > ifdef clutter. (Ruifeng) > [Wang, Yipeng] Looks good to me and I believe it is more organized now than before. Thanks for the patch! I did not fully test on x86 though, will rely on the CI or any other reviewer's input.
A little bit grammar issue in commit message: "into separate files" Acked-by: Yipeng Wang <yipeng1.w...@intel.com>
