On Fri, Mar 25, 2022 at 3:32 PM Aaron Conole <acon...@redhat.com> wrote: > David Marchand <david.march...@redhat.com> writes: > > > Though devtools/checkpatches.sh is run as part of our CI, some other > > (not well known) checks could help when run in private repositories > > before submitting to the mailing list and even when run from the > > ovsrobot. > > > > Most of them require a git history or checked sources to run. > > And I can't guarantee there won't be false positives. > > > > Add a new job just for those checks so that it won't block compilation > > tests in other jobs. > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > Looks good to me. The extra fetches shouldn't take too long (since we > refresh main branch weekly to the robot repository). The checks look > good - and since it's part of the same build workflow, it will be > reported in the same place (and hopefully in a readable form).
Thanks for the review. Thomas expressed a concern that the check-git-log.sh script has too many false positives. I will respin removing this check. -- David Marchand
