Hi Marvin, On 4/11/22 17:04, David Marchand wrote:
Those optimisations were only enabled with make builds, fix the meson part.Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx") Cc: sta...@dpdk.org Signed-off-by: David Marchand <david.march...@redhat.com> --- drivers/net/virtio/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build index 01a333ada2..d78b8278c6 100644 --- a/drivers/net/virtio/meson.build +++ b/drivers/net/virtio/meson.build @@ -30,11 +30,11 @@ if arch_subdir == 'x86' c_args: [cflags, '-mavx512f', '-mavx512bw', '-mavx512vl']) objs += virtio_avx512_lib.extract_objects('virtio_rxtx_packed.c') if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0')) - cflags += '-DVHOST_GCC_UNROLL_PRAGMA' + cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA' elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0')) - cflags += '-DVHOST_CLANG_UNROLL_PRAGMA' + cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA' elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0')) - cflags += '-DVHOST_ICC_UNROLL_PRAGMA' + cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA' endif endif endif
I wonder how this was not spotted by the Intel performance lab? Is that these optimizations do not bring performance gains, or it is not benchmark-ed? Anyway: Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> Thanks, Maxime
