On Tue, Apr 5, 2022 at 6:37 PM David Marchand <david.march...@redhat.com> wrote: > > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation > between main and threads and factorize the rest as common code. > Thread id are now logged as string in a common format across OS. > > Note: libabigail flags this change as breaking ABI in clang builds: > > 1 function with some indirect sub-type change: > > [C] 'function int rte_eal_remote_launch(int (void*)*, void*, unsigned > int)' at eal_common_launch.c:35:1 has some indirect sub-type > changes: > parameter 1 of type 'int (void*)*' changed: > in pointed to type 'function type int (void*)' at rte_launch.h:31:1: > entity changed from 'function type int (void*)' to 'typedef > lcore_function_t' at rte_launch.h:31:1 > type size hasn't changed > > This is being investigated on libabigail side. > For now, we don't have much choice but to waive reports on this symbol. > > Signed-off-by: David Marchand <david.march...@redhat.com> > Acked-by: Morten Brørup <m...@smartsharesystems.com> > Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
Added a note in the commitlog about Windows EAL threads affinity (from a parallel discussion with Tyler), and applied. Thanks. -- David Marchand
