> -----Original Message----- > From: Richardson, Bruce <bruce.richard...@intel.com> > Sent: Tuesday, April 12, 2022 16:39 > To: Zeng, ZhichaoX <zhichaox.z...@intel.com> > Cc: Wang, Haiyue <haiyue.w...@intel.com>; dev@dpdk.org > Subject: Re: [DPDK] drivers/net/ixgbe: remove expired symbols > > On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.z...@intel.com wrote: > > From: zhichao zeng <zhichaox.z...@intel.com> > > > > Remove expired experimental symbols. > > > > Signed-off-by: zhichao zeng <zhichaox.z...@intel.com> > > --- > > drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++--------------- > > drivers/net/ixgbe/version.map | 10 +++++----- > > 2 files changed, 10 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h > > b/drivers/net/ixgbe/rte_pmd_ixgbe.h > > index eef6f6661c..4f1fe6029d 100644 > > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h > > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h > > @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port); > > * - (-ENODEV) if *port* invalid. > > * - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed > > */ > > -__rte_experimental > > -int > > -rte_pmd_ixgbe_mdio_lock(uint16_t port); > > +int rte_pmd_ixgbe_mdio_lock(uint16_t port); > > > > I don't see the value in rewriting the prototypes to be all on one line as > part of this change. Just remove the experimental tag line in this patch, > to keep the diff as small as possible.
+1, yes, clean patch. ;-) > > /Bruce
